Playlist command #599

kthezelais · 2019-12-09T12:07:57Z

I add a playlist command. This feature is used to store tracks into a parallel list of the queue, and this list of tracks can be run on the queue when the user use the command ;;playlist run.

You can find some details on how to use this new command below :

The command ;;playlist Allows you to configure the playlist:

- add <search>: add a title from a search. Then enter the command ;;playlist [1-5] to choose a title from the search list.

- copy: copy the queue into the playlist. If the playlist is not empty, enter the command ;;playlist [1-2] (1: overwrite the playlist, 2: do nothing).

- list: display title's list of the playlist.

- remove <option>: delete one or more titles from the playlist:
     - without option: displays the list of titles in the playlist.
     - all: delete all the titles in the playlist.
     - <number>: delete the title associated with the <number> parameter.

- run <option>: adds all the titles from playlist to the queue.
     - without option: add the titles in order.
     - random: add the titles in the mess.

claassistantio · 2019-12-09T12:08:17Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Killian THEZELAIS seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

freyacodes · 2019-12-09T12:15:29Z

FredBoat/src/main/java/fredboat/command/music/control/PlayListCommand.java

+
+public class PlayListCommand extends JCommand implements IMusicCommand, ICommandRestricted {
+
+    private List<AudioTrackContext> playlist;


This fundamentally doesn't work. You're sharing the same playlist between everyone. It also doesn't persist between restarts.

Doing something like this this the right way would require working with the database, and even then I would do things differently.

Killian THEZELAIS added 2 commits December 9, 2019 12:27

Create a PlaylistCommand

c2ca018

Correct some miss copy into CommandInitializer

3b6a7fa

freyacodes suggested changes Dec 9, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Playlist command #599

Playlist command #599

kthezelais commented Dec 9, 2019 •

edited

Loading

claassistantio commented Dec 9, 2019

freyacodes Dec 9, 2019


		public class PlayListCommand extends JCommand implements IMusicCommand, ICommandRestricted {

		private List<AudioTrackContext> playlist;

Playlist command #599

Are you sure you want to change the base?

Playlist command #599

Conversation

kthezelais commented Dec 9, 2019 • edited Loading

claassistantio commented Dec 9, 2019

freyacodes Dec 9, 2019

Choose a reason for hiding this comment

kthezelais commented Dec 9, 2019 •

edited

Loading